ref: move SentryExtraContextProvider singleton to SentryDependencyContainer #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3244 +/- ##
=============================================
+ Coverage 89.177% 89.207% +0.030%
=============================================
Files 502 502
Lines 54210 54250 +40
Branches 19462 19476 +14
=============================================
+ Hits 48343 48395 +52
+ Misses 5002 4994 -8
+ Partials 865 861 -4 Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 89d72e7 | 1222.60 ms | 1252.78 ms | 30.18 ms |
| 24b4df1 | 1240.98 ms | 1253.98 ms | 13.00 ms |
| 7c5d161 | 1224.38 ms | 1249.66 ms | 25.28 ms |
| efb0147 | 1245.26 ms | 1266.94 ms | 21.68 ms |
| 89b12eb | 1236.02 ms | 1246.63 ms | 10.61 ms |
| 4259afd | 1222.12 ms | 1249.74 ms | 27.62 ms |
| fdfe96b | 1227.90 ms | 1242.56 ms | 14.66 ms |
| 98a8c16 | 1206.40 ms | 1232.14 ms | 25.74 ms |
| d760c3f | 1228.58 ms | 1246.22 ms | 17.64 ms |
| 7cd187e | 1204.78 ms | 1235.86 ms | 31.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 89d72e7 | 20.76 KiB | 431.87 KiB | 411.11 KiB |
| 24b4df1 | 20.76 KiB | 425.77 KiB | 405.01 KiB |
| 7c5d161 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
| efb0147 | 22.84 KiB | 403.52 KiB | 380.67 KiB |
| 89b12eb | 20.76 KiB | 432.88 KiB | 412.11 KiB |
| 4259afd | 20.76 KiB | 419.70 KiB | 398.94 KiB |
| fdfe96b | 20.76 KiB | 419.70 KiB | 398.95 KiB |
| 98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
| d760c3f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
| 7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
|
Something broke CI |
…lize-SentryExtraContextProvider-singleton
…lize-SentryExtraContextProvider-singleton
armcknight
deleted the
armcknight/ref/centralize-SentryExtraContextProvider-singleton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another singleton that was passed in a few inits, that should be just accessed via the dependency container.
#skip-changelog